This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
crypto: use domains for any callback-taking method #8380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds domains coverage for pdbkdf2, pseudoRandomBytes, and randomBytes. All others should be covered by event emitters. Fixes nodejs#5801.
|
LGTM, is it everything that you wanted to get in? |
|
I was taking a slightly different route, can you do something like this? https://gist.github.com/tjfontaine/2eb6373d6e593ae13a52 making an inline convenience function for |
|
@tjfontaine this looks nice. |
| var crypto = require('crypto'); | ||
| var domain = require('domain'); | ||
| var d = domain.create(); | ||
| d.on('error', function (e) { console.log('got', e.message); }); |
There was a problem hiding this comment.
perhaps validate the number of times the error handler runs? and potentially has the errors we care about?
|
thanks, landed in 6e689ec |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds domains coverage for pdbkdf2, pseudoRandomBytes, and randomBytes.
All others should be covered by event emitters.
Fixes #5801.