This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
doc: add note about key derivation #8580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmetcalf
force-pushed
the
crypto-cipher
branch
from
3b96113 to
16fbbfc
Compare
| @@ -191,6 +191,10 @@ written data is used to compute the hash. Once the writable side of | |||
| the stream is ended, use the `read()` method to get the enciphered | |||
| contents. The legacy `update` and `final` methods are also supported. | |||
|
|
|||
| Note: `createCipher` uses a very [weak key derevation method][], it is | |||
There was a problem hiding this comment.
I would not go into emotional spectre here :) Use just weak, or even better tell people that it derives key + iv pair using just the input key string.
Also, I'd go into a bit of more detail and tell people what this derivation method actually does.
adds a note to the crypto docs passing along the advice that openssl gives about what key derivation function they recommend.
calvinmetcalf
force-pushed
the
crypto-cipher
branch
from
16fbbfc to
bb0f389
Compare
|
ok updated |
|
LGTM |
|
@indutny are you waiting on anything from me on this? |
mscdex
pushed a commit
to mscdex/node
that referenced
this pull request
Dec 25, 2014
adds a note to the crypto docs passing along the advice that openssl gives about what key derivation function they recommend. PR-URL: nodejs#8580 Reviewed-By: Fedor Indutny <fedor@indutny.com>
piscisaureus
pushed a commit
to piscisaureus/node2
that referenced
this pull request
Jan 10, 2015
adds a note to the crypto docs passing along the advice that openssl gives about what key derivation function they recommend. PR-URL: nodejs/node-v0.x-archive#8580 Reviewed-by: Fedor Indutny <fedor@indutny.com> Cherry-picked-from: nodejs/node-v0.x-archive@7dbc024
|
Appears to have already landed in io.js (or at least some derivation of it) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a note to the crypto docs passing along
the advice that openssl gives about what
key derivation function they recommend.
#8578