Ensuring private Buffer require in lib/* files

[odeke-em]

This addresses issue #8588 in which Buffer was being used globally in lib/* files. Any redefinition of Buffer when using a repl would crash. Credits to @indutny and @vkurchatkin for providing the remedy.

[indutny]

cc @trevnorris

@odeke-em : could you please take a look at CONTRIBUTING.md to see how your commit message should be improved to be accepted? ;)

[odeke-em]

Thanks @indutny , I have taken a look at it and made an amend to the commit message. Please help me check if it is appropriate.

[trevnorris]

Commit message first line should not be longer than 50 characters.

Other than that LGTM.

[odeke-em]

Thanks for the patience.

[trevnorris]

Thanks. Now, I just barely ran the tests. Things are falling over quite badly. Issue is there are places where require('buffer') isn't yet available. In src/node.js we get around this by using NativeModule but that doesn't exist elsewhere. Again, we're relying on a global (require()) and assuming all modules will be available all the time. That just isn't the case.

[odeke-em]

Hey @trevnorris, I guess I bit on more than I could chew: could I kindly ask if someone with more knowledge of the internals [ like a core developer ] look at this since we'd probably want this done well? Instead of me holding you and @indutny back.

[trevnorris]

@odeke-em No worries at all. Honestly I can't think of a good solution ATM. I'll leave this open and if you want to keep experimenting with it feel free.

[vkurchatkin]

Looks like a simple case of circular dependencies. Try this:

diff --git a/lib/assert.js b/lib/assert.js
index 0ab3f49..5bd30ea 100644
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -24,7 +24,7 @@

 // UTILITY
 var util = require('util');
-var Buffer = require('buffer').Buffer;
+var b = require('buffer');
 var pSlice = Array.prototype.slice;

 // 1. The assert module provides functions that throw
@@ -145,7 +145,7 @@ function _deepEqual(actual, expected) {
   if (actual === expected) {
     return true;

-  } else if (Buffer.isBuffer(actual) && Buffer.isBuffer(expected)) {
+  } else if (b.Buffer.isBuffer(actual) && b.Buffer.isBuffer(expected)) {
     if (actual.length != expected.length) return false;

     for (var i = 0; i < actual.length; i++) {

[odeke-em]

@trevnorris For sure, will do.

[odeke-em]

@vkurchatkin Thanks! Your solution cuts the deal, tests related to those modules on mine pass. Only thing tripped out on mine are errors related to EMFILE [too many files open], but I don't think that's directly related to the issue at hand.

[odeke-em]

@trevnorris ping!

[trevnorris]

Thanks. Merged into 523929c.

[odeke-em]

Thanks for merging this in.