This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: i18n: fix issue with icu toolset dependencies #8681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So what I did here is to make the `icutools` library actually contain the entire ICU dependencies needed for host-side tools. Sadly, this will build ICU twice, but avoids conflicts between host and target side. This all seems like a gyp bug of some sort, but without docs for `toolsets`, who’s to say? I removed the `icuio` library as a separate target, because it was only used by the host-side tools. ref: nodejs#7676 Update: fix for Windows
srl295
force-pushed
the
srl-v0.12-fixdeps
branch
from
fa515fd
to
658e8ae
Compare
trevnorris
pushed a commit
that referenced
this pull request
Nov 12, 2014
So what I did here is to make the icutools library actually contain the entire ICU dependencies needed for host-side tools. Sadly, this will build ICU twice, but avoids conflicts between host and target side. This all seems like a gyp bug of some sort, but without docs for toolsets, who’s to say? I removed the icuio library as a separate target, because it was only used by the host-side tools. PR-URL: #8681 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks much. Merged in ea4dc7d. |
|
Just tried node-v5.0.0 with --with-intl=system-icu and I get the following error: Not sure, what host is all about. Any hints? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So what I did here is to make the
icutoolslibraryactually contain the entire ICU dependencies needed
for host-side tools. Sadly, this will build ICU twice,
but avoids conflicts between host and target side.
This all seems like a gyp bug of some sort, but without
docs for
toolsets, who’s to say?I removed the
icuiolibrary, because it was onlyused by the host-side tools.
ref: #7676