This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: i18n: icutrim.py needs to support BIG-endian machines.
#8712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this may not affect anything until powerpc support lands in v8, etc. I am tracking some other related issues in https://github.com/srl295/node/issues/7 and this commit is itself a port of srl295/node@ba8ab91
srl295
changed the title
icutrim.py needs to support little-endian machines.icutrim.py needs to support BIG-endian machines.
|
fyi @sxa555 |
|
/cc @mdawsonibm |
trevnorris
pushed a commit
that referenced
this pull request
Nov 13, 2014
Note that this may not affect anything until powerpc support lands in v8. Related: https://github.com/srl295/node/issues/7 Related: srl295/node@ba8ab91 PR-URL: #8712 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks much. Landed in 855b1c9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am tracking some other related ppc/aix issues in https://github.com/srl295/node/issues/7
and this commit is itself a port of srl295/node@ba8ab91
This is itself to support joyent/node/#7676
Update: this is about big endian support, of course.