This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
test: add test for spawnSync() env option #8845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added a commit
to nodejs/node
that referenced
this pull request
Dec 9, 2014
PR-URL: nodejs/node-v0.x-archive#8845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks, landed in nodejs/node@8e272df. |
cjihrig
added a commit
that referenced
this pull request
Dec 11, 2014
PR-URL: #8845 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks. Landed in 4bba870. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
envoption tospawnSync()is currently broken. A fix is available in #8546, but no test is provided. This PR adds a test, which will fail until #8546 is merged.