This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
events.markdown document improvements #8911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements to events.markdown documentation per nodejs#8853 (same fix as before but rebased on joyent/v0.10
| This event is emitted any time someone adds a new listener. It is unspecified | ||
| if `listener` is in the list returned by `emitter.listeners(event)`. | ||
| This event is emitted any time a listener is added. When this event is triggered, | ||
| the listener may not yet have been added to the array of listeners for the `event`. |
There was a problem hiding this comment.
I think this wording is a vast improvement.
The same change should be applied to removeListener, which has the same awful wording, and would benefit from your cleanup.
With that addition, I'd be ++++.
There was a problem hiding this comment.
Done. jasnell/node@c91b2fa
Per comment nodejs#8911 (comment) ...
|
+1 from me, looks much improved. |
|
Thanks, landed in 4853639 with a reworded commit message. btw, can you make sure your commits line up with our style https://github.com/joyent/node/blob/master/CONTRIBUTING.md#commit |
|
+1 will do |
jasnell
added a commit
to jasnell/node-joyent
that referenced
this pull request
Jan 5, 2015
Clarify that adding or removing a listener is not idempotent. RE: nodejs#8853 PR: nodejs#8911 PR-URL: nodejs#8911 Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
jasnell
added a commit
to jasnell/node-joyent
that referenced
this pull request
Jan 5, 2015
Clarify that adding or removing a listener is not idempotent. RE: nodejs#8853 PR: nodejs#8911 PR-URL: nodejs#8911 Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
piscisaureus
pushed a commit
to piscisaureus/node2
that referenced
this pull request
Jan 10, 2015
Clarify that adding or removing a listener is not idempotent. PR-URL: nodejs/node-v0.x-archive#8911 Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com> Cherry-picked-from: nodejs/node-v0.x-archive@4853639
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to events.markdown documentation per #8853 (same fix as before but rebased on joyent/v0.10