This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
fix assert() spec #9003
Closed
fix assert() spec #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"message" argument is optional for both assert() and assert.ok().
|
They are the same function, so it makes sense. LGTM |
|
LGTM. @cjihrig feel free to merge. |
cjihrig
pushed a commit
that referenced
this pull request
Jan 20, 2015
The message argument is optional for both assert() and assert.ok(). This commit makes message optional for assert(). PR-URL: #9003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
cjihrig
pushed a commit
that referenced
this pull request
Jan 20, 2015
The message argument is optional for both assert() and assert.ok(). This commit makes message optional for assert(). PR-URL: #9003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 13, 2015
The message argument is optional for both assert() and assert.ok(). This commit makes message optional for assert(). PR-URL: nodejs/node-v0.x-archive#9003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
May 11, 2017
Allows Symbol to be converted to String so it can be included in the error. Conflicts: lib/events.js Fixes: nodejs#9003 Backport-PR-URL: nodejs/node#12459 PR-URL: nodejs/node#9021 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Allows Symbol to be converted to String so it can be included in the error. Conflicts: lib/events.js Fixes: nodejs#9003 Backport-PR-URL: nodejs/node#12459 PR-URL: nodejs/node#9021 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"message" argument is optional for both assert() and assert.ok().