Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

deps: updated libuv to 1.2.1 #9050

Closed
wants to merge 1 commit into from
Closed

deps: updated libuv to 1.2.1 #9050

wants to merge 1 commit into from

Conversation

saghul
Copy link
Member

@saghul saghul commented Jan 16, 2015

We made quite some bugfixes and uv_try_write got implemented on Windows, which improves the writes performance. API is backwards compatible and ABI hasn't changed.

R=@tjfontaine, @cjihrig

This should close #8988

@saghul
Copy link
Member Author

saghul commented Jan 16, 2015

Oh, tests do pass locally (Linux), I hope Jenkins agrees :-)

@cjihrig
Copy link

cjihrig commented Jan 16, 2015

Rubber stamp LGTM. Let's see what Jenkins says.

@cjihrig
Copy link

cjihrig commented Jan 16, 2015

Oh, and @tjfontaine does this need to wait or can it go in 0.12?

@misterdjules
Copy link

In my opinion, we should land that post 0.11.15 now that we closed all outstanding issues/PRs in this milestone and the build is all green.

@saghul
Copy link
Member Author

saghul commented Jan 23, 2015

Gentle reminder, now that 0.11.15 is out :-)

@tjfontaine
Copy link

We're pretty long in the tooth in the process towards releasing v0.12 -- upgrading libuv at this point is too much change before we release. I would prefer we push this to master.

@saghul
Copy link
Member Author

saghul commented Jan 23, 2015

@tjfontaine While I understand, don't let the version number deceive you, it's not a major upgrade. We now follow semver so we had to bump the minor twice because a couple of new (small) features where added.

FWIW, iojs has run all releases since 1.0 and thanks to that we were able to fix a couple of regressions like #8988. If you ship Node with 1.0 #8988 is broken.

@misterdjules misterdjules added this to the 0.12.1 milestone Feb 3, 2015
@misterdjules
Copy link

Adding it to the 0.12.1 milestone, even though a more recent version of libuv than 1.2.1 might be preferable at that time. Thank you @saghul for your help and support.

@saghul
Copy link
Member Author

saghul commented Feb 4, 2015

@misterdjules no worries. I'll update this PR with 1.3.0 in the upcoming days.

@saghul
Copy link
Member Author

saghul commented Feb 9, 2015

I opened a new PR here: #9165 since I cannot the change the title of this one, and it would be misleading.

@saghul saghul closed this Feb 9, 2015
@misterdjules misterdjules removed this from the 0.12.1 milestone Mar 17, 2015
@misterdjules
Copy link

Cleared the 0.12.1 milestone since it never landed and has been superseded by #9179.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants