-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Conversation
Oh, tests do pass locally (Linux), I hope Jenkins agrees :-) |
Rubber stamp LGTM. Let's see what Jenkins says. |
Oh, and @tjfontaine does this need to wait or can it go in 0.12? |
In my opinion, we should land that post 0.11.15 now that we closed all outstanding issues/PRs in this milestone and the build is all green. |
Gentle reminder, now that 0.11.15 is out :-) |
We're pretty long in the tooth in the process towards releasing v0.12 -- upgrading libuv at this point is too much change before we release. I would prefer we push this to master. |
@tjfontaine While I understand, don't let the version number deceive you, it's not a major upgrade. We now follow semver so we had to bump the minor twice because a couple of new (small) features where added. FWIW, iojs has run all releases since 1.0 and thanks to that we were able to fix a couple of regressions like #8988. If you ship Node with 1.0 #8988 is broken. |
Adding it to the 0.12.1 milestone, even though a more recent version of libuv than 1.2.1 might be preferable at that time. Thank you @saghul for your help and support. |
@misterdjules no worries. I'll update this PR with 1.3.0 in the upcoming days. |
I opened a new PR here: #9165 since I cannot the change the title of this one, and it would be misleading. |
Cleared the 0.12.1 milestone since it never landed and has been superseded by #9179. |
We made quite some bugfixes and uv_try_write got implemented on Windows, which improves the writes performance. API is backwards compatible and ABI hasn't changed.
R=@tjfontaine, @cjihrig
This should close #8988