Skip to content

Commit

Permalink
deps: silence internal V8 deprecation warning
Browse files Browse the repository at this point in the history
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Jul 7, 2024
1 parent 297de95 commit 57ed1ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/base/optional.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace base {

// These aliases are deprecated, use std::optional directly.
template <typename T>
using Optional [[deprecated]] = std::optional<T>;
using Optional = std::optional<T>;

using std::in_place;
using std::make_optional;
Expand Down

0 comments on commit 57ed1ba

Please sign in to comment.