./configure --debug not working without --experimental-enable-pointer-compression

[mmarchini]

$ ./configure --debug
Node.js configure: Found Python 3.7.5...
INFO: configure completed successfully

$ make -j32 BUILDTYPE=Debug -C out/
...
  TOUCH db289bf03238b5b9fbfd145a08c728f10a435a3f.intermediate
  ACTION generating: "/home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/obj.target/v8_zlib/geni/snapshot.cc" "/home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/obj.target/v8_zlib/geni/embedded.S" db289bf03238b5b9fbfd145a08c728f10a435a3f.intermediate


#
# Fatal error in ../deps/v8/src/codegen/x64/assembler-x64.h, line 123
# Debug check failed: SmiValuesAre31Bits().
#
#
#
#FailureMessage Object: 0x7fffc67ccf10
==== C stack trace ===============================

    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::base::debug::StackTrace::StackTrace()+0x12) [0x55ae6bcf2f72]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(+0x127007a) [0x55ae6af5707a]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(V8_Fatal(char const*, int, char const*, ...)+0x17b) [0x55ae6af4d13b]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(+0x126616b) [0x55ae6af4d16b]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::internal::Builtins::Generate_InterpreterEntryTrampoline(v8::internal::MacroAssembler*)+0xaa2) [0x55ae6ba30ae2]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(+0x182f8ce) [0x55ae6b5168ce]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal(v8::internal::Isolate*)+0x996) [0x55ae6b517876]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*)+0x58) [0x55ae6af44728]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::internal::Isolate::Init(v8::internal::ReadOnlyDeserializer*, v8::internal::StartupDeserializer*)+0x1166) [0x55ae6a5420c6]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::SnapshotCreator::SnapshotCreator(v8::Isolate*, long const*, v8::StartupData*)+0xfd) [0x55ae6a3c803d]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(v8::internal::CreateSnapshotDataBlobInternal(v8::SnapshotCreator::FunctionCodeHandling, char const*, v8::Isolate*)+0x4d) [0x55ae6aa4d3dd]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(main+0x2bc) [0x55ae6a3b0adc]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f2cff9141e3]
    /home/mmarchini/workspace/nodejs/node-v8-lala/out/Debug/mksnapshot(_start+0x2e) [0x55ae6a3bc3ae]
Illegal instruction (core dumped)
make: *** [tools/v8_gypfiles/v8_snapshot.target.mk:17: db289bf03238b5b9fbfd145a08c728f10a435a3f.intermediate] Error 132
rm 789e532d012df1d22207d570710447c224257f33.intermediate 14c5b9873273637da0c069b6f6e7e03ae83559fc.intermediate 377a8ebb7c015d9afd89119f3cc53cd93545cecb.intermediate db289bf03238b5b9fbfd145a08c728f10a435a3f.intermediate
make: Leaving directory '/home/mmarchini/workspace/nodejs/node-v8-lala/out'

With --experimental-enable-pointer-compression it works though.

[targos]

@nodejs/v8

[mmarchini]

FWIW:

# on V8 8.2.141
$ gn gen --args='is_debug=true v8_enable_pointer_compression=false v8_enable_31bit_smis_on_64bit_arch=false' out/x64.debug.test
Done. Made 143 targets from 86 files in 80ms

$ ninja -C out/x64.debug.test d8
ninja: Entering directory `out/x64.debug.test'
[1410/1418] ACTION //:run_mksnapshot_default(//build/toolchain/linux:clang_x64)
FAILED: gen/embedded.S snapshot_blob.bin 
python ../../tools/run.py ./mksnapshot --turbo_instruction_scheduling --target_os=linux --target_arch=x64 --embedded_src gen/embedded.S --embedded_variant Default --random-seed 314159265 --startup_blob snapshot_blob.bin --native-code-counters --verify-heap


#
# Fatal error in ../../src/codegen/x64/assembler-x64.h, line 123
# Debug check failed: SmiValuesAre31Bits().
#
#
#
#FailureMessage Object: 0x7fffad2da500
==== C stack trace ===============================

    /home/mmarchini/workspace/chromium/v8/v8/out/x64.debug.test/libv8_libbase.so(v8::base::debug::StackTrace::StackTrace()+0x13) [0x7f76dc880cd3]
    /home/mmarchini/workspace/chromium/v8/v8/out/x64.debug.test/libv8_libplatform.so(+0x112ad) [0x7f76dc84e2ad]
    /home/mmarchini/workspace/chromium/v8/v8/out/x64.debug.test/libv8_libbase.so(V8_Fatal(char const*, int, char const*, ...)+0x153) [0x7f76dc8764c3]
    /home/mmarchini/workspace/chromium/v8/v8/out/x64.debug.test/libv8_libbase.so(+0x1ad55) [0x7f76dc875d55]
    ./mksnapshot(+0x17704e7) [0x55966a77f4e7]
    ./mksnapshot(+0x169959c) [0x55966a6a859c]
    ./mksnapshot(v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal(v8::internal::Isolate*)+0x9bd) [0x55966a66d48d]
    ./mksnapshot(v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*)+0x17) [0x55966a1702f7]
    ./mksnapshot(v8::internal::Isolate::Init(v8::internal::ReadOnlyDeserializer*, v8::internal::StartupDeserializer*)+0xe9b) [0x5596698642cb]
    ./mksnapshot(v8::internal::Isolate::InitWithoutSnapshot()+0xd) [0x55966986341d]
    ./mksnapshot(v8::SnapshotCreator::SnapshotCreator(v8::Isolate*, long const*, v8::StartupData*)+0xc9) [0x5596695b9c79]
    ./mksnapshot(v8::internal::CreateSnapshotDataBlobInternal(v8::SnapshotCreator::FunctionCodeHandling, char const*, v8::Isolate*)+0x43) [0x559669f51e33]
    ./mksnapshot(+0x59bfc0) [0x5596695aafc0]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f76dbd711e3]
    ./mksnapshot(_start+0x2a) [0x5596695a5e3a]
ninja: build stopped: subcommand failed.

[mmarchini]

Upstream bug: https://bugs.chromium.org/p/v8/issues/detail?id=10257

[mmarchini]

Should be fixed on lkgr

[targos]

the fix was reverted for now: https://bugs.chromium.org/p/v8/issues/detail?id=10257#c10

[mmarchini]

Re-landed on https://chromium-review.googlesource.com/c/v8/v8/+/2077682

[gengjiawen]

Re-landed on chromium-review.googlesource.com/c/v8/v8/+/2077682

Do we need to cherrypick it or it will auto sync to this repo ?

[mmarchini]

It should automatically sync