Blockers for the update to V8 8.0

[targos]

We've got quite a few things to fix this time!

• Failing test-inspector-multisession-ws
• Failing test-assert
• S390x fails to build
• FreeBSD fails to build
• SmartOS fails to build
• Windows fails to build (VS2019)
• Windows fails to build (VS2017)
• Broken debug build
• incomplete zlib.gyp
• V8 zlib target fails for cross-compilation
• Debug build not working without --experimental-enable-pointer-compression

[bnoordhuis]

@targos Does #130 (comment) mean that the "incomplete zlib.gyp" bullet point should be checked off?

[targos]

@bnoordhuis I suppose we can check it off because it's no longer a blocker, but I didn't implement the conditions to load optimized code depending on the platform.

[ghost]

Is this still being worked on? I would love to have the latest v8.

[gengjiawen]

Is this still being worked on? I would love to have the latest v8.

Yeap. We have just fixed build issue on vs2019. Still some work todo. See #127 (comment) for update.

[SFx2018]

any news? :D looking forward for it :D

[addaleax]

@SFx2018 There is a checklist at the top of this PR :)

[hashseed]

V8 had to make some changes to make building with zlib work again: https://chromium-review.googlesource.com/c/v8/node-ci/+/2037570

[SFx2018]

any ETA for release for nodejs?

[gengjiawen]

vs2017 build issue has been resolved.

[targos]

CI: https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/450/

[gengjiawen]

With #147 and #140 fixed in upstream, hopefully we have only two test case failed.

[liudonghua123]

Glad to here that, I hope I can use v8 8.0 as soon as possible. :haha:

[mmarchini]

#120 was not fixed upstream yet though :/

[gengjiawen]

#120 was not fixed upstream yet though :/

got it wrong, should be #140

[MKRhere]

#140 is closed (fixed upstream), should the last point be checked off?

[gengjiawen]

V8 8.1 landed on Node.js master (nodejs/node#32116).

[mmarchini]

Yes, this can be closed now. Hooray!