Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken debug build #129

Closed
targos opened this issue Dec 4, 2019 · 2 comments
Closed

Broken debug build #129

targos opened this issue Dec 4, 2019 · 2 comments

Comments

@targos
Copy link
Member

targos commented Dec 4, 2019

https://ci.nodejs.org/job/node-test-commit-linux-containered/16511/nodes=ubuntu1804_sharedlibs_debug_x64/console

11:30:08 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Debug/obj.target/v8_base_without_compiler/deps/v8/src/heap/incremental-marking.o: In function `v8::internal::IncrementalMarking::Hurry()':
11:30:08 /home/iojs/build/workspace/node-test-commit-linux-containered/out/../deps/v8/src/heap/incremental-marking.cc:724: undefined reference to `unsigned long v8::internal::MarkCompactCollector::ProcessMarkingWorklist<(v8::internal::MarkCompactCollector::MarkingWorklistProcessingMode)0>(unsigned long)'
11:30:08 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Debug/obj.target/v8_base_without_compiler/deps/v8/src/heap/incremental-marking.o: In function `v8::internal::IncrementalMarking::V8Step(double, v8::internal::IncrementalMarking::CompletionAction, v8::internal::StepOrigin)':
11:30:08 /home/iojs/build/workspace/node-test-commit-linux-containered/out/../deps/v8/src/heap/incremental-marking.cc:1061: undefined reference to `unsigned long v8::internal::MarkCompactCollector::ProcessMarkingWorklist<(v8::internal::MarkCompactCollector::MarkingWorklistProcessingMode)0>(unsigned long)'
11:30:08 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Debug/obj.target/v8_base_without_compiler/deps/v8/src/heap/incremental-marking.o: In function `v8::internal::IncrementalMarking::Finalize()':
11:30:08 /home/iojs/build/workspace/node-test-commit-linux-containered/out/../deps/v8/src/heap/incremental-marking.cc:724: undefined reference to `unsigned long v8::internal::MarkCompactCollector::ProcessMarkingWorklist<(v8::internal::MarkCompactCollector::MarkingWorklistProcessingMode)0>(unsigned long)'
11:30:08 collect2: error: ld returned 1 exit status
@targos targos mentioned this issue Dec 4, 2019
Closed
11 tasks
@addaleax
Copy link
Member

addaleax commented Dec 4, 2019

https://chromium-review.googlesource.com/c/v8/v8/+/1950971

@targos
Copy link
Member Author

targos commented Dec 5, 2019

Fixed upstream. Thank you @addaleax !

@targos targos closed this as completed Dec 5, 2019
joyeecheung pushed a commit to joyeecheung/v8 that referenced this issue Jan 16, 2020
@addaleax
[heap] generate definitions for ProcessMarkingWorklist()
94ec429 
Since other files now call this template function, where no definition
of it is available, definitions need to be generated explicitly.

This fixes Node.js debug builds with the current V8 master branch.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1940250
Refs: nodejs/node-v8#129
Change-Id: Icc99f7a4c3669452ade65229d6ae48b49e2da0e4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950971
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65339}
qtprojectorg pushed a commit to qt/qtwebengine-chromium that referenced this issue Mar 26, 2020
@addaleax @valdmann
[Backport] generate definitions for ProcessMarkingWorklist()
5c93497 
Since other files now call this template function, where no definition
of it is available, definitions need to be generated explicitly.

This fixes Node.js debug builds with the current V8 master branch.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1940250
Refs: nodejs/node-v8#129
Change-Id: Icc99f7a4c3669452ade65229d6ae48b49e2da0e4
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65339}
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @targos