-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build broken on SmartOS #125
Comments
I'll take a look at this, but it might be a few days. I'm currently sick, plus I have a few other things going on ATM. |
No problem, thanks! |
@targos can you try cjihrig@ce607e4, cjihrig@cfd6103, and cjihrig@4177a69. Only the third commit is SmartOS specific. The first two are about postmortem metadata, which should be broken on all platforms. |
@cjihrig thanks, I applied your commits. Now it errors with: |
Ping @cjihrig |
I'm working on setting up a new SmartOS instance to test on. I haven't forgotten about this. |
@targos, looking at this again, I think the constants in cjihrig@4177a69 are just missing an extra |
Also, unrelated to this issue, but related to updating V8, have you seen nodejs/node#30916 (comment)? I don't think that issue can be addressed in the main repo yet. |
Applied fix to canary. Thank you! |
https://ci.nodejs.org/job/node-test-commit-smartos/29426/nodes=smartos18-64/console
/cc @nodejs/platform-smartos
The text was updated successfully, but these errors were encountered: