Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken on SmartOS #125

Closed
targos opened this issue Dec 4, 2019 · 9 comments
Closed

Build broken on SmartOS #125

targos opened this issue Dec 4, 2019 · 9 comments

Comments

@targos
Copy link
Member

targos commented Dec 4, 2019

https://ci.nodejs.org/job/node-test-commit-smartos/29426/nodes=smartos18-64/console

11:42:50 dtrace: failed to compile script src/v8ustack.d: line 414: failed to resolve V8DBG_CLASS_CONSSTRING__FIRST_OFFSET__INT: Unknown variable name

/cc @nodejs/platform-smartos

@cjihrig
Copy link

cjihrig commented Dec 4, 2019

I'll take a look at this, but it might be a few days. I'm currently sick, plus I have a few other things going on ATM.

@targos
Copy link
Member Author

targos commented Dec 4, 2019

No problem, thanks!

@cjihrig
Copy link

cjihrig commented Dec 8, 2019

@targos can you try cjihrig@ce607e4, cjihrig@cfd6103, and cjihrig@4177a69. Only the third commit is SmartOS specific. The first two are about postmortem metadata, which should be broken on all platforms.

@targos
Copy link
Member Author

targos commented Dec 10, 2019

@cjihrig thanks, I applied your commits.

Now it errors with: 16:00:19 dtrace: failed to compile script src/v8ustack.d: line 414: failed to resolve V8DBG_CLASS_CONSSTRING__FIRST_STRING: Unknown variable name.
Maybe V8 changed it already in the mean time?

@targos
Copy link
Member Author

targos commented Dec 17, 2019

Ping @cjihrig

@cjihrig
Copy link

cjihrig commented Dec 17, 2019

I'm working on setting up a new SmartOS instance to test on. I haven't forgotten about this.

@cjihrig
Copy link

cjihrig commented Dec 17, 2019

@targos, looking at this again, I think the constants in cjihrig@4177a69 are just missing an extra _. I think cjihrig@d677605 should do the trick instead.

@cjihrig
Copy link

cjihrig commented Dec 17, 2019

Also, unrelated to this issue, but related to updating V8, have you seen nodejs/node#30916 (comment)? I don't think that issue can be addressed in the main repo yet.

@targos
Copy link
Member Author

targos commented Jan 13, 2020

Applied fix to canary. Thank you!

@targos targos closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants