Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_symbols.cc uses deprecated V8 APIs #30916

Closed
targos opened this issue Dec 12, 2019 · 2 comments
Closed

node_symbols.cc uses deprecated V8 APIs #30916

targos opened this issue Dec 12, 2019 · 2 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@targos
Copy link
Member

targos commented Dec 12, 2019

Warnings in canary:

[849/962] CXX obj/src/libnode.node_symbols.o
../../src/node_symbols.cc: In function ‘void node::symbols::Initialize(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)’:
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:164:3: note: in expansion of macro ‘V’
  164 |   V(handle_onclose_symbol, "handle_onclose")                                  \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:165:3: note: in expansion of macro ‘V’
  165 |   V(no_message_symbol, "no_message_symbol")                                   \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:166:3: note: in expansion of macro ‘V’
  166 |   V(oninit_symbol, "oninit")                                                  \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
../../src/node_symbols.cc:21:55: warning: ‘v8::Local<v8::Value> v8::Symbol::Name() const’ is deprecated: Use Symbol::Description() [-Wdeprecated-declarations]
   21 |       ->Set(env->context(), env->PropertyName()->Name(), env->PropertyName())  \
      |                                                       ^
../../src/env.h:167:3: note: in expansion of macro ‘V’
  167 |   V(owner_symbol, "owner")                                                    \
      |   ^
../../src/node_symbols.cc:23:3: note: in expansion of macro ‘PER_ISOLATE_SYMBOL_PROPERTIES’
   23 |   PER_ISOLATE_SYMBOL_PROPERTIES(V)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/util.h:27,
                 from ../../src/aliased_buffer.h:7,
                 from ../../src/env-inl.h:27,
                 from ../../src/node_symbols.cc:1:
../../deps/v8/include/v8.h:3263:16: note: declared here
 3263 |   Local<Value> Name() const { return Description(); }
      |                ^~~~
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Dec 12, 2019
cjihrig added a commit to cjihrig/node-v8 that referenced this issue Dec 14, 2019
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
@cjihrig
Copy link
Contributor

cjihrig commented Dec 14, 2019

@targos can you pull cjihrig/node-v8@2911f8d into the canary branch to address this issue.

@targos
Copy link
Member Author

targos commented Jan 13, 2020

Applied fix to canary. Thank you!

@targos targos closed this as completed Jan 13, 2020
targos pushed a commit that referenced this issue Jan 13, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 13, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 14, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
targos pushed a commit that referenced this issue Jan 17, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 17, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 18, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 19, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 20, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 21, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
targos pushed a commit that referenced this issue Jan 27, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 27, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 28, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Jan 29, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
targos pushed a commit that referenced this issue Feb 2, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 2, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 3, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 4, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 5, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 6, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
targos pushed a commit that referenced this issue Feb 11, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 11, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
targos pushed a commit that referenced this issue Feb 14, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 14, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 15, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 28, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Feb 29, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 1, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 2, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 3, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
mmarchini pushed a commit to mmarchini/node that referenced this issue Mar 4, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs#30916
mmarchini pushed a commit to mmarchini/node that referenced this issue Mar 6, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs#30916
mmarchini pushed a commit that referenced this issue Mar 8, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 8, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
mmarchini pushed a commit to mmarchini/node that referenced this issue Mar 9, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 9, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
mmarchini pushed a commit that referenced this issue Mar 11, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 12, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 13, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 14, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 15, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
mmarchini pushed a commit to mmarchini/node that referenced this issue Mar 16, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs#30916
mmarchini pushed a commit that referenced this issue Mar 16, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 16, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 17, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this issue Mar 18, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
mmarchini pushed a commit that referenced this issue Mar 18, 2020
This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: #30916

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants