deps,src,test: update postmortem constants for V8 7.1 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
until 81a3c699d6eef936452ac3d10c7c59a2c1e38c0c
until 4274d2f1905b5e4c3cf613635a0db79fb99a9409 missing: 408896a8b41751fea92e482c5eb4b858e7ffe68d
enable v8_enable_embedded_builtins reorder conditions proccessing for `run_mksnapshot`
Update V8's postmortem metadata generation script for V8 7.1.
The V8 7.1 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_class_JSArrayBuffer__byte_length__Object Use: v8dbg_class_JSArrayBuffer__byte_length__size_t - v8dbg_class_JSArrayBufferView__raw_byte_length__Object Use: v8dbg_class_JSArrayBufferView__byte_length__size_t - v8dbg_class_JSArrayBufferView__raw_byte_offset__Object Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t - v8dbg_class_String__length__SMI Use: v8dbg_class_String__length__int32_t Refs: v8/v8@5cfe1a6 Refs: v8/v8@c7a0049
Update a postmortem constant used by the ustack helper which changed while moving to V8 7.1.
nodejs-ci
force-pushed
the
canary
branch
4 times, most recently
from
014be7e
to
96b72e6
Compare
|
Thanks! I'll include those directly in the 7.1 PR. |
|
Included in nodejs/node#23423 |
|
The V8 change is upstreamed at https://chromium-review.googlesource.com/c/v8/v8/+/1278014. |
joyeecheung
pushed a commit
to joyeecheung/v8
that referenced
this pull request
Oct 25, 2018
See: nodejs/node-v8#84 Change-Id: Ia1d4b110367c795e952e8e3d0a067f601a306077 Reviewed-on: https://chromium-review.googlesource.com/c/1278014 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56781}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #82
I'll need to upstream the
depscommit. Also, cc: @mmarchini for the second commit, which will impact llnode.