Skip to content

Commit

Permalink
test: replace anonymous closure functions with arrow function
Browse files Browse the repository at this point in the history
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Amanpreet-03 authored and codebytere committed Jan 13, 2019
1 parent d148bfc commit 01532b8
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions test/parallel/test-error-reporting.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const fixtures = require('../common/fixtures');

function errExec(script, callback) {
const cmd = `"${process.argv[0]}" "${fixtures.path(script)}"`;
return exec(cmd, function(err, stdout, stderr) {
return exec(cmd, (err, stdout, stderr) => {
// There was some error
assert.ok(err);

Expand All @@ -43,39 +43,39 @@ const syntaxErrorMessage = /\bSyntaxError\b/;


// Simple throw error
errExec('throws_error.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error.js', common.mustCall((err, stdout, stderr) => {
assert.ok(/blah/.test(stderr));
}));


// Trying to JSON.parse(undefined)
errExec('throws_error2.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error2.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));


// Trying to JSON.parse(undefined) in nextTick
errExec('throws_error3.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error3.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));


// throw ILLEGAL error
errExec('throws_error4.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error4.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));

// Specific long exception line doesn't result in stack overflow
errExec('throws_error5.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error5.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));

// Long exception line with length > errorBuffer doesn't result in assertion
errExec('throws_error6.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error6.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));

// Object that throws in toString() doesn't print garbage
errExec('throws_error7.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error7.js', common.mustCall((err, stdout, stderr) => {
assert.ok(/<toString\(\) threw exception/.test(stderr));
}));

0 comments on commit 01532b8

Please sign in to comment.