Skip to content

Commit

Permalink
stream: simplify isUint8Array helper
Browse files Browse the repository at this point in the history
The fallback code is no longer used when exporting to readable-stream.

Refs: #29475

PR-URL: #29514
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
addaleax authored and targos committed Sep 20, 2019
1 parent fb311ed commit 018754c
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions lib/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@

'use strict';

const { Object } = primordials;

const { Buffer } = require('buffer');
const pipeline = require('internal/streams/pipeline');
const eos = require('internal/streams/end-of-stream');
Expand All @@ -43,27 +41,7 @@ Stream.finished = eos;
// Backwards-compat with node 0.4.x
Stream.Stream = Stream;

// Internal utilities
try {
const types = require('internal/util/types');
if (types && typeof types.isUint8Array === 'function') {
Stream._isUint8Array = types.isUint8Array;
} else {
// This throws for Node < 4.2.0 because there's no util binding and
// returns undefined for Node < 7.4.0.
// Please do not convert process.binding() to internalBinding() here.
// This is for compatibility with older versions when loaded as
// readable-stream.
Stream._isUint8Array = process.binding('util').isUint8Array;
}
} catch (e) { // eslint-disable-line no-unused-vars
}

if (!Stream._isUint8Array) {
Stream._isUint8Array = function _isUint8Array(obj) {
return Object.prototype.toString.call(obj) === '[object Uint8Array]';
};
}
Stream._isUint8Array = require('internal/util/types').isUint8Array;

const version = process.version.substr(1).split('.');
if (version[0] === 0 && version[1] < 12) {
Expand Down

0 comments on commit 018754c

Please sign in to comment.