Skip to content

Commit

Permalink
Revert "src: ignore GCC -Wcast-function-type for v8.h"
Browse files Browse the repository at this point in the history
This reverts commit f21cf45 as this has
now been included in the V8 version being used.

PR-URL: #35758
Refs: v8/v8@f08cbfd
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
danbev authored and targos committed Nov 3, 2020
1 parent 6211ffd commit 01d7c46
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
7 changes: 0 additions & 7 deletions src/string_bytes.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,7 @@

// Decodes a v8::Local<v8::String> or Buffer to a raw char*

#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h"
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif
#include "env-inl.h"

#include <string>
Expand Down
7 changes: 0 additions & 7 deletions test/cctest/test_aliased_buffer.cc
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h"
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif
#include "aliased_buffer.h"
#include "node_test_fixture.h"

Expand Down

0 comments on commit 01d7c46

Please sign in to comment.