Skip to content

Commit

Permalink
naming convention changes from pr review
Browse files Browse the repository at this point in the history
  • Loading branch information
jarrodconnolly committed Feb 12, 2019
1 parent 3a4af6e commit 06f7337
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/js_native_api_v8.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2892,11 +2892,10 @@ napi_status napi_create_date(napi_env env,
NAPI_PREAMBLE(env);
CHECK_ARG(env, result);

auto maybe_date = v8::Date::New(env->context(), time);
v8::MaybeLocal<v8::Value> maybe_date = v8::Date::New(env->context(), time);
CHECK_MAYBE_EMPTY(env, maybe_date, napi_generic_failure);

auto v8_resolver = maybe_date.ToLocalChecked();
*result = v8impl::JsValueFromV8LocalValue(v8_resolver);
*result = v8impl::JsValueFromV8LocalValue(maybe_date.ToLocalChecked());

return GET_RETURN_STATUS(env);
}
Expand Down

0 comments on commit 06f7337

Please sign in to comment.