Skip to content

Commit

Permalink
v8: remove --harmony-top-level-await
Browse files Browse the repository at this point in the history
PR-URL: #40226
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
GeoffreyBooth authored and targos committed Oct 9, 2021
1 parent 7bc0d7c commit 07ea5c6
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 28 deletions.
7 changes: 0 additions & 7 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -803,13 +803,6 @@ int ProcessGlobalArgs(std::vector<std::string>* args,
return 12;
}

// TODO(mylesborins): remove this when the harmony-top-level-await flag
// is removed in V8
if (std::find(v8_args.begin(), v8_args.end(),
"--no-harmony-top-level-await") == v8_args.end()) {
v8_args.push_back("--harmony-top-level-await");
}

auto env_opts = per_process::cli_options->per_isolate->per_env;
if (std::find(v8_args.begin(), v8_args.end(),
"--abort-on-uncaught-exception") != v8_args.end() ||
Expand Down
4 changes: 0 additions & 4 deletions test/message/esm_display_syntax_error.mjs

This file was deleted.

8 changes: 0 additions & 8 deletions test/message/esm_display_syntax_error.out

This file was deleted.

8 changes: 0 additions & 8 deletions test/parallel/test-no-harmony-top-level-await.mjs

This file was deleted.

1 change: 0 additions & 1 deletion tools/code_cache/mkcodecache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ int main(int argc, char* argv[]) {
#endif // _WIN32

v8::V8::SetFlagsFromString("--random_seed=42");
v8::V8::SetFlagsFromString("--harmony-top-level-await");

if (argc < 2) {
std::cerr << "Usage: " << argv[0] << " <path/to/output.cc>\n";
Expand Down

0 comments on commit 07ea5c6

Please sign in to comment.