Skip to content

Commit

Permalink
benchmark: remove extra spacing in http options
Browse files Browse the repository at this point in the history
This commit removes the benchmark spacing modification in
`client-request-body.js` and `end-vs-write-end.js` which adds two spaces
to the end of some variables to make sure the lines line up.

The reason behind this is that its totally pointless (the lines don't
actually line up with it) and it disallows you to parse the output with
a tool like awk, or at least makes it a lot harder.

PR-URL: #650
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  • Loading branch information
brendanashworth authored and Fishrock123 committed Jan 30, 2015
1 parent e17e6fb commit 083c421
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion benchmark/http/client-request-body.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var bench = common.createBenchmark(main, {
dur: [5],
type: ['asc', 'utf', 'buf'],
bytes: [32, 256, 1024],
method: ['write', 'end '] // two spaces added to line up each row
method: ['write', 'end']
});

function main(conf) {
Expand Down
2 changes: 1 addition & 1 deletion benchmark/http/end-vs-write-end.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var bench = common.createBenchmark(main, {
type: ['asc', 'utf', 'buf'],
kb: [64, 128, 256, 1024],
c: [100],
method: ['write', 'end '] // two spaces added to line up each row
method: ['write', 'end']
});

function main(conf) {
Expand Down

0 comments on commit 083c421

Please sign in to comment.