events: deal with no arguments case

nodejs · May 31, 2020 · 0a2edb5 · 0a2edb5
1 parent 2935f72
commit 0a2edb5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -50,7 +50,7 @@ class Event {
     this.#cancelable = !!cancelable;
     this.#bubbles = !!bubbles;
     this.#composed = !!composed;
-    this.#type = String(type);
+    this.#type = '' + type;
     // isTrusted is special (LegacyUnforgeable)
     Object.defineProperty(this, 'isTrusted', {
       get() { return false; },

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -49,6 +49,7 @@ ok(EventTarget);
 
   ev.preventDefault();
   strictEqual(ev.defaultPrevented, true);
+  throws(() => new Event(Symbol()), TypeError);
 }
 {
   const ev = new Event('foo');