Skip to content

Commit

Permalink
fixup! doc: expand on squashing and rebasing to land a PR
Browse files Browse the repository at this point in the history
  • Loading branch information
legendecas committed Jul 14, 2023
1 parent 45f80af commit 0c4e188
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions doc/contributing/collaborator-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -540,11 +540,11 @@ For pull requests from first-time contributors, be
[welcoming](#welcoming-first-time-contributors). Also, verify that their git
settings are to their liking.

If the pull request contains more than one commit, it can be landed either by
squashing into one commit or by rebasing all the commits. Generally, a
collaborator should land the pull request with squashing. If the pull request
has more than one self-contained subsystem commits, a collaborator may land it
with rebasing.
If a pull request contains more than one commit, it can be landed either by
squashing into one commit or by rebasing all the commits, or a mix of the two.
Generally, a collaborator should land a pull request by squashing. If a pull
request has more than one self-contained subsystem commits, a collaborator
may land it as several commits.

All commits should be self-contained, meaning every commit should pass all
tests. This makes it much easier when bisecting to find a breaking change.
Expand Down

0 comments on commit 0c4e188

Please sign in to comment.