Skip to content

Commit

Permalink
test: fix over-dependence on native promise impl
Browse files Browse the repository at this point in the history
In later versions of V8, the stack trace will be different than our
current expectations for Promise methods.

PR-URL: #11437
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
ofrobots authored and MylesBorins committed Mar 9, 2017
1 parent 3444458 commit 0ddad76
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/message/unhandled_promise_trace_warnings.out
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
at getAsynchronousRejectionWarningObject (internal/process/promises.js:*)
at rejectionHandled (internal/process/promises.js:*)
at *
at Promise.then (native)
at Promise.catch (native)
at Promise.then *
at Promise.catch *
at Immediate.setImmediate (*test*message*unhandled_promise_trace_warnings.js:*)
at *
at *
Expand Down

0 comments on commit 0ddad76

Please sign in to comment.