http: refactor to remove redundant argument of _deferToConnect

nodejs · May 8, 2021 · 0e4595b · 0e4595b
1 parent 52e4fb5
commit 0e4595b
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -817,8 +817,8 @@ function onSocketNT(req, socket, err) {
   }
 }
 
-ClientRequest.prototype._deferToConnect = _deferToConnect;
-function _deferToConnect(method, arguments_, cb) {
+ClientRequest.prototype._deferToConnect =
+function _deferToConnect(method, arguments_) {
   // This function is for calls that need to happen once the socket is
   // assigned to this request and writable. It's an important promisy
   // thing for all the socket calls that happen either now
@@ -828,9 +828,6 @@ function _deferToConnect(method, arguments_, cb) {
   const callSocketMethod = () => {
     if (method)
       ReflectApply(this.socket[method], this.socket, arguments_);
-
-    if (typeof cb === 'function')
-      cb();
   };
 
   const onSocket = () => {
@@ -846,7 +843,7 @@ function _deferToConnect(method, arguments_, cb) {
   } else {
     onSocket();
   }
-}
+};
 
 ClientRequest.prototype.setTimeout = function setTimeout(msecs, callback) {
   if (this._ended) {