Skip to content

Commit

Permalink
benchmark: refactor _http-benchmarkers.js
Browse files Browse the repository at this point in the history
Refactor _http-benchmarkers.js:

* The file used a mixture of inline callbacks with the `function`
  keyword and arrow functions. Use arrow functions for consistency.
* The file used a mixture of trailing commas and no trailing commas. Use
  trailing commas for consistency.

PR-URL: #25803
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott committed Feb 1, 2019
1 parent 32c7ad6 commit 0fd6e64
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions benchmark/_http-benchmarkers.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AutocannonBenchmarker {
'-c', options.connections,
'-j',
'-n',
`http://127.0.0.1:${options.port}${options.path}`
`http://127.0.0.1:${options.port}${options.path}`,
];
const child = child_process.spawn(this.executable, args);
return child;
Expand Down Expand Up @@ -59,7 +59,7 @@ class WrkBenchmarker {
'-d', options.duration,
'-c', options.connections,
'-t', 8,
`http://127.0.0.1:${options.port}${options.path}`
`http://127.0.0.1:${options.port}${options.path}`,
];
const child = child_process.spawn(this.executable, args);
return child;
Expand Down Expand Up @@ -170,7 +170,7 @@ const http_benchmarkers = [
new AutocannonBenchmarker(),
new TestDoubleBenchmarker('http'),
new TestDoubleBenchmarker('http2'),
new H2LoadBenchmarker()
new H2LoadBenchmarker(),
];

const benchmarkers = {};
Expand All @@ -188,7 +188,7 @@ exports.run = function(options, callback) {
path: '/',
connections: 100,
duration: 5,
benchmarker: exports.default_http_benchmarker
benchmarker: exports.default_http_benchmarker,
}, options);
if (!options.benchmarker) {
callback(new Error('Could not locate required http benchmarker. See ' +
Expand Down Expand Up @@ -216,7 +216,7 @@ exports.run = function(options, callback) {
let stdout = '';
child.stdout.on('data', (chunk) => stdout += chunk.toString());

child.once('close', function(code) {
child.once('close', (code) => {
const elapsed = process.hrtime(benchmarker_start);
if (code) {
let error_message = `${options.benchmarker} failed with ${code}.`;
Expand Down

0 comments on commit 0fd6e64

Please sign in to comment.