CR

nodejs · Aug 9, 2022 · 1058218 · 1058218
1 parent 0d4af69
commit 1058218
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/internal/assert/calltracker.js b/lib/internal/assert/calltracker.js
@@ -2,8 +2,10 @@
 
 const {
   ArrayPrototypePush,
+  ArrayPrototypeSlice,
   Error,
   FunctionPrototype,
+  ObjectFreeze,
   Proxy,
   ReflectApply,
   SafeSet,
@@ -36,7 +38,8 @@ class CallTrackerContext {
   }
 
   track(thisArg, args) {
-    ArrayPrototypePush(this.#calls, { thisArg, arguments: args });
+    args = ObjectFreeze(ArrayPrototypeSlice(args));
+    ArrayPrototypePush(this.#calls, ObjectFreeze({ thisArg, arguments: args }));
   }
 
   get delta() {
@@ -47,7 +50,7 @@ class CallTrackerContext {
     this.#calls = [];
   }
   getCalls() {
-    return this.#calls;
+    return ObjectFreeze(ArrayPrototypeSlice(this.#calls));
   }
 
   report() {

diff --git a/test/parallel/test-assert-calltracker-getCalls.js b/test/parallel/test-assert-calltracker-getCalls.js
@@ -28,6 +28,15 @@ describe('assert.CallTracker.getCalls()', { concurrency: true }, () => {
       assert.throws(() => tracker.getCalls(fn), { code: 'ERR_INVALID_ARG_VALUE' });
     });
   });
+
+  it('should return a frozen object', () => {
+    const fn = tracker.calls();
+    fn();
+    const calls = tracker.getCalls(fn);
+    assert.throws(() => calls.push(1), /object is not extensible/);
+    assert.throws(() => Object.assign(calls[0], { foo: 'bar' }), /object is not extensible/);
+    assert.throws(() => calls[0].arguments.push(1), /object is not extensible/);
+  });
 });
 
 describe('assert.CallTracker.reset()', () => {