Read all results for subdirectories in opendir

Fixes #48820
nodejs · Jul 18, 2023 · 11cedfe · 11cedfe
1 parent b361ad7
commit 11cedfe
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/lib/internal/fs/dir.js b/lib/internal/fs/dir.js
@@ -166,18 +166,22 @@ class Dir {
       pathModule.toNamespacedPath(dirent.path),
       this[kDirOptions].encoding,
       undefined,
-      ctx,
+      ctx
     );
     handleErrorFromBinding(ctx);
-    const result = handle.read(
-      this[kDirOptions].encoding,
-      this[kDirOptions].bufferSize,
-      undefined,
-      ctx,
-    );
+    while (true) {
+      const result = handle.read(
+        this[kDirOptions].encoding,
+        this[kDirOptions].bufferSize,
+        undefined,
+        ctx,
+      );
 
-    if (result) {
-      this.processReadResult(dirent.path, result);
+      if (result) {
+        this.processReadResult(dirent.path, result);
+      } else {
+        break;
+      }
     }
 
     handle.close(undefined, ctx);
@@ -206,7 +210,7 @@ class Dir {
       this[kDirOptions].encoding,
       this[kDirOptions].bufferSize,
       undefined,
-      ctx,
+      ctx
     );
     handleErrorFromBinding(ctx);