child_process: fix bad abort signal leak

Move abort signal validation to before spawn is executed so that the file is not leaked.
nodejs · Feb 7, 2021 · 15bdcda · 15bdcda
1 parent d6e9446
commit 15bdcda
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -758,11 +758,14 @@ function spawnWithSignal(file, args, options) {
   const opts = options && typeof options === 'object' && ('signal' in options) ?
     { ...options, signal: undefined } :
     options;
-  const child = spawn(file, args, opts);
 
-  if (options && options.signal) {
+  if (options?.signal) {
     // Validate signal, if present
     validateAbortSignal(options.signal, 'options.signal');
+  }
+  const child = spawn(file, args, opts);
+
+  if (options && options.signal) {
     function kill() {
       if (child._handle) {
         child._handle.kill(options.killSignal || 'SIGTERM');