Skip to content

Commit

Permalink
url: warn when operation requires ICU
Browse files Browse the repository at this point in the history
  • Loading branch information
aduh95 committed Sep 24, 2020
1 parent 9687348 commit 189677f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/node_url.cc
Original file line number Diff line number Diff line change
Expand Up @@ -787,11 +787,13 @@ bool ToASCII(const std::string& input, std::string* output) {
#else
// Intentional non-ops if ICU is not present.
bool ToUnicode(const std::string& input, std::string* output) {
std::cerr << "Warning: Cannot convert to unicode when intl is disabled!\n";
*output = input;
return true;
}

bool ToASCII(const std::string& input, std::string* output) {
std::cerr << "Warning: Cannot convert to ASCII when intl is disabled!\n";
*output = input;
return true;
}
Expand Down

0 comments on commit 189677f

Please sign in to comment.