Skip to content

Commit

Permalink
test: improve coverage for process.umask
Browse files Browse the repository at this point in the history
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: #16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
evanlucas authored and MylesBorins committed Nov 28, 2017
1 parent 0689ea6 commit 1fe3e86
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions test/parallel/test-umask.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,11 @@ assert.strictEqual(parseInt(mask, 8), process.umask(old));
assert.strictEqual(old, process.umask());
// 2. If the test fails, process.umask() will return 0
assert.strictEqual(old, process.umask());

assert.throws(() => {
process.umask({});
}, /argument must be an integer or octal string/);

assert.throws(() => {
process.umask('123x');
}, /invalid octal string/);

0 comments on commit 1fe3e86

Please sign in to comment.