lib: support more attributes for early hint link

PR-URL: #44874 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Oct 14, 2022 · 2649aab · 2649aab
1 parent 267a03e
commit 2649aab
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/internal/validators.js b/lib/internal/validators.js
@@ -441,7 +441,7 @@ function validateUnion(value, name, union) {
   }
 }
 
-const linkValueRegExp = /^(?:<[^>]*>;)\s*(?:rel=(")?[^;"]*\1;?)\s*(?:(?:as|anchor|title)=(")?[^;"]*\2)?$/;
+const linkValueRegExp = /^(?:<[^>]*>;)\s*(?:rel=(")?[^;"]*\1;?)\s*(?:(?:as|anchor|title|crossorigin|disabled|fetchpriority|rel|referrerpolicy)=(")?[^;"]*\2)?$/;
 
 /**
  * @param {any} value

diff --git a/test/parallel/test-validators.js b/test/parallel/test-validators.js
@@ -12,6 +12,7 @@ const {
   validateString,
   validateInt32,
   validateUint32,
+  validateLinkHeaderValue,
 } = require('internal/validators');
 const { MAX_SAFE_INTEGER, MIN_SAFE_INTEGER } = Number;
 const outOfRangeError = {
@@ -154,3 +155,15 @@ const invalidArgValueError = {
     code: 'ERR_INVALID_ARG_TYPE'
   }));
 }
+
+{
+  // validateLinkHeaderValue type validation.
+  [
+    ['</styles.css>; rel=preload; as=style', '</styles.css>; rel=preload; as=style'],
+    ['</styles.css>; rel=preload; title=hello', '</styles.css>; rel=preload; title=hello'],
+    ['</styles.css>; rel=preload; crossorigin=hello', '</styles.css>; rel=preload; crossorigin=hello'],
+    ['</styles.css>; rel=preload; disabled=true', '</styles.css>; rel=preload; disabled=true'],
+    ['</styles.css>; rel=preload; fetchpriority=high', '</styles.css>; rel=preload; fetchpriority=high'],
+    ['</styles.css>; rel=preload; referrerpolicy=origin', '</styles.css>; rel=preload; referrerpolicy=origin'],
+  ].forEach(([value, expected]) => assert.strictEqual(validateLinkHeaderValue(value), expected));
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -441,7 +441,7 @@ function validateUnion(value, name, union) { @@
       }
     }
-    const linkValueRegExp = /^(?:<[^>]*>;)\s*(?:rel=(")?[^;"]*\1;?)\s*(?:(?:as|anchor|title)=(")?[^;"]*\2)?$/;
+    const linkValueRegExp = /^(?:<[^>]*>;)\s*(?:rel=(")?[^;"]*\1;?)\s*(?:(?:as|anchor|title|crossorigin|disabled|fetchpriority|rel|referrerpolicy)=(")?[^;"]*\2)?$/;
     /**
      * @param {any} value
@@ Expand Down @@