fixup: don't read more if failed

nodejs · Nov 17, 2021 · 27999bf · 27999bf
1 parent aabfd75
commit 27999bf
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/lib/internal/streams/operators.js b/lib/internal/streams/operators.js
@@ -70,7 +70,7 @@ module.exports.map = function map(stream, fn, options) {
     try {
       return [null, await val];
     } catch (err) {
-      return [err, null];
+      stream.destroy(err);
     }
   }
 
@@ -82,21 +82,21 @@ module.exports.map = function map(stream, fn, options) {
   }
 
   function pump () {
-    while (queue.length < concurrency) {
-      let val = stream.read();
-      if (val === null) {
-        return;
-      }
-      try {
+    try {
+      while (queue.length < concurrency) {
+        let val = stream.read();
+        if (val === null) {
+          return;
+        }
         val = fn(val, { signal });
         if (val && typeof val.then === 'function') {
           enqueue(wrap(val));
         } else {
           enqueue([null, val]);
         }
-      } catch (err) {
-        enqueue([err, null]);
       }
+    } catch (err) {
+      stream.destroy(err);
     }
   }