Skip to content

Commit

Permalink
cluster: fix closing dgram sockets in cluster workers throws errors
Browse files Browse the repository at this point in the history
This fixes closing dgram sockets right after binding in cluster
workers will throws `ERR_SOCKET_DGRAM_NOT_RUNNING` errors.
  • Loading branch information
oyyd committed Jul 7, 2022
1 parent b993789 commit 2c12374
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/internal/cluster/child.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ cluster._getServer = function(obj, options, cb) {
});

obj.once('listening', () => {
// short-lived sockets might have been closed
if (!indexes.has(indexesKey)) {
return;
}
cluster.worker.state = 'listening';
const address = obj.address();
message.act = 'listening';
Expand Down
38 changes: 38 additions & 0 deletions test/parallel/test-dgram-cluster-close-in-listening.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
'use strict';
// Ensure that closing dgram sockets in 'listening' callbacks of cluster workers
// won't throw errors.

const common = require('../common');
const dgram = require('dgram');
const cluster = require('cluster');

if (cluster.isPrimary) {
for (let i = 0; i < 3; i += 1) {
cluster.fork();
}
} else {
const buf = Buffer.alloc(1024, 42);
const socket = dgram.createSocket('udp4');

socket.on('error', common.mustNotCall());

socket.on('listening', common.mustCall(() => {
socket.close();
}));

socket.on('close', common.mustCall(() => {
cluster.worker.disconnect();
}));

// Get a random port for send
const portGetter = dgram.createSocket('udp4')
.bind(0, 'localhost', common.mustCall(() => {
// Adds a listener to 'listening' to send the data when
// the socket is available
socket.send(buf, 0, buf.length,
portGetter.address().port,
portGetter.address().address);

portGetter.close();
}));
}

0 comments on commit 2c12374

Please sign in to comment.