Merge branch 'nodejs:master' into async

.eslintignore

@@ -7,4 +7,5 @@ tools/icu
 tools/lint-md/lint-md.mjs
 benchmark/tmp
 doc/**/*.js
+!doc/api_assets/*.js
 !.eslintrc.js

.eslintrc.js

@@ -35,6 +35,9 @@ Module._findPath = (request, paths, isMain) => {
 
 module.exports = {
   root: true,
+  env: {
+    es2022: true,
+  },
   extends: ['eslint:recommended', 'plugin:jsdoc/recommended'],
   plugins: ['jsdoc', 'markdown', 'node-core'],
   parser: '@babel/eslint-parser',
@@ -163,7 +166,7 @@ module.exports = {
     'keyword-spacing': 'error',
     'linebreak-style': ['error', 'unix'],
     'max-len': ['error', {
-      code: 80,
+      code: 120,
       ignorePattern: '^// Flags:',
       ignoreRegExpLiterals: true,
       ignoreTemplateLiterals: true,
@@ -186,7 +189,6 @@ module.exports = {
     'no-proto': 'error',
     'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
-    /* eslint-disable max-len */
     'no-restricted-properties': [
       'error',
       {
@@ -239,7 +241,6 @@ module.exports = {
         message: 'Use Number.isNaN() instead of the global isNaN() function.',
       },
     ],
-    /* eslint-enable max-len */
     'no-return-await': 'error',
     'no-self-compare': 'error',
     'no-tabs': 'error',
@@ -259,6 +260,7 @@ module.exports = {
     'no-useless-concat': 'error',
     'no-useless-constructor': 'error',
     'no-useless-return': 'error',
+    'no-var': 'error',
     'no-void': 'error',
     'no-whitespace-before-property': 'error',
     'object-curly-newline': 'error',
@@ -297,10 +299,7 @@ module.exports = {
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
     // ESLint recommended rules that we disable
-    'no-cond-assign': 'off',
-    'no-empty': 'off',
     'no-inner-declarations': 'off',
-    'no-prototype-builtins': 'off',
 
     // JSDoc recommended rules that we disable
     'jsdoc/require-jsdoc': 'off',
@@ -319,27 +318,29 @@ module.exports = {
     'node-core/no-duplicate-requires': 'error',
   },
   globals: {
-    AbortController: 'readable',
-    AbortSignal: 'readable',
-    Atomics: 'readable',
-    BigInt: 'readable',
-    BigInt64Array: 'readable',
-    BigUint64Array: 'readable',
-    Blob: 'readable',
-    DOMException: 'readable',
-    Event: 'readable',
-    EventTarget: 'readable',
-    MessageChannel: 'readable',
-    BroadcastChannel: 'readable',
-    MessageEvent: 'readable',
-    MessagePort: 'readable',
-    TextEncoder: 'readable',
-    TextDecoder: 'readable',
-    queueMicrotask: 'readable',
-    globalThis: 'readable',
-    btoa: 'readable',
-    atob: 'readable',
-    performance: 'readable',
-    structuredClone: 'readable',
+    ByteLengthQueuingStrategy: 'readable',
+    CompressionStream: 'readable',
+    CountQueuingStrategy: 'readable',
+    Crypto: 'readable',
+    CryptoKey: 'readable',
+    DecompressionStream: 'readable',
+    fetch: 'readable',
+    FormData: 'readable',
+    ReadableStream: 'readable',
+    ReadableStreamDefaultReader: 'readable',
+    ReadableStreamBYOBReader: 'readable',
+    ReadableStreamBYOBRequest: 'readable',
+    ReadableByteStreamController: 'readable',
+    ReadableStreamDefaultController: 'readable',
+    Response: 'readable',
+    TextDecoderStream: 'readable',
+    TextEncoderStream: 'readable',
+    TransformStream: 'readable',
+    TransformStreamDefaultController: 'readable',
+    ShadowRealm: 'readable',
+    SubtleCrypto: 'readable',
+    WritableStream: 'readable',
+    WritableStreamDefaultWriter: 'readable',
+    WritableStreamDefaultController: 'readable',
   },
 };

.github/CODEOWNERS

@@ -107,10 +107,8 @@
 
 /benchmark/misc/startup.js @nodejs/startup
 /src/node.cc @nodejs/startup
-/src/node_code_cache_stub.cc @nodejs/startup
 /src/node_native_module* @nodejs/startup
 /lib/internal/bootstrap/* @nodejs/startup
-/tools/code_cache/* @nodejs/startup
 /tools/snapshot/* @nodejs/startup
 
 # V8

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -1,4 +1,4 @@
-name: "\U0001F41B Bug report"
+name: 🐛 Bug report
 description: Create a report to help us improve
 body:
   - type: markdown

.github/ISSUE_TEMPLATE/2-feature-request.yml

@@ -1,13 +1,16 @@
-name: "\U0001F680 Feature request"
+name: 🚀 Feature request
 description: Suggest an idea for this project
-labels: ["feature request"]
+labels: [feature request]
 body:
   - type: markdown
     attributes:
       value: |
         Thank you for suggesting an idea to make Node.js better.
 
         Please fill in as much of the following form as you're able.
+
+        For more information on how the project manages feature
+        requests, see [Feature request management](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md).
   - type: textarea
     attributes:
       label: What is the problem this feature will solve?

.github/ISSUE_TEMPLATE/3-api-ref-docs-problem.yml

@@ -1,6 +1,6 @@
-name: "\U0001F4D7 Open an issue regarding the Node.js API reference docs"
+name: 📗 Open an issue regarding the Node.js API reference docs
 description: Let us know about any problematic API reference documents
-labels: ["doc"]
+labels: [doc]
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml

@@ -1,6 +1,6 @@
 name: Report a flaky test
 description: Report a flaky test in our CI
-labels: ["flaky-test"]
+labels: [flaky-test]
 body:
   - type: markdown
     attributes:

.github/label-pr-config.yml

@@ -67,7 +67,7 @@ subSystemLabels:
   /^tools\/make-v8/: tools, v8 engine, needs-ci
   /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
   /^tools\/(code_cache|snapshot)/: needs-ci
-  /^tools\/build-addons.js/: needs-ci
+  /^tools\/build-addons.mjs/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools
@@ -85,7 +85,7 @@ subSystemLabels:
   /^deps\/nghttp2\//: http2
   /^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
   /^deps\/nghttp3\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
-  /^deps\/([^/]+)/: $1
+  /^deps\/([^/]+)/: dependencies, $1
 
   ## JS subsystems
   # Oddities first

.github/workflows/authors.yml

@@ -1,8 +1,8 @@
-name: "authors update"
+name: Authors update
 on:
   schedule:
     # Run once a week at 00:05 AM UTC on Sunday.
-    - cron: '5 0 * * 0'
+    - cron: 5 0 * * 0
 
   workflow_dispatch:
 
@@ -11,11 +11,11 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: "tools/update-authors.js"  # Run the AUTHORS tool
+      - run: tools/update-authors.mjs  # Run the AUTHORS tool
       - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
@@ -24,8 +24,8 @@ jobs:
           body: >
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
-            `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
-          branch: "actions/authors-update"  # Custom branch *just* for this Action.
-          commit-message: "meta: update AUTHORS"
+            `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
+          branch: actions/authors-update  # Custom branch *just* for this Action.
+          commit-message: 'meta: update AUTHORS'
           labels: meta
-          title: "meta: update AUTHORS"
+          title: 'meta: update AUTHORS'

.github/workflows/auto-start-ci.yml

@@ -6,13 +6,15 @@ on:
     # optimistic, it can take longer to run.
     # To understand why `schedule` is used instead of other events, refer to
     # ./doc/contributing/commit-queue.md
-    - cron: "*/5 * * * *"
+    - cron: '*/5 * * * *'
+
+concurrency: ${{ github.workflow }}
 
 env:
   NODE_VERSION: lts/*
 
 jobs:
-  get_prs_for_ci:
+  get-prs-for-ci:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     outputs:
@@ -29,20 +31,20 @@ jobs:
                   --limit 100
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  startCI:
-    needs: get_prs_for_ci
-    if: needs.get_prs_for_ci.outputs.numbers != ''
+  start-ci:
+    needs: get-prs-for-ci
+    if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
 
-      # Install dependencies
       - name: Install Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ env.NODE_VERSION }}
+
       - name: Install node-core-utils
         run: npm install -g node-core-utils
 
@@ -55,6 +57,6 @@ jobs:
           ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
 
       - name: Start the CI
-        run: ./tools/actions/start-ci.sh ${{ needs.get_prs_for_ci.outputs.numbers }}
+        run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-tarball.yml

@@ -4,10 +4,10 @@ on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
     paths-ignore:
-      - '.mailmap'
+      - .mailmap
       - '**.md'
-      - 'AUTHORS'
-      - 'doc/**'
+      - AUTHORS
+      - doc/**
       - .github/**
       - '!.github/workflows/build-tarball.yml'
   push:
@@ -17,28 +17,31 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
-      - '.mailmap'
+      - .mailmap
       - '**.md'
-      - 'AUTHORS'
-      - 'doc/**'
+      - AUTHORS
+      - doc/**
       - .github/**
       - '!.github/workflows/build-tarball.yml'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
 env:
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
-    env:
-      PYTHON_VERSION: '3.10'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -52,27 +55,25 @@ jobs:
           mkdir tarballs
           mv *.tar.gz tarballs
       - name: Upload tarball artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: tarballs
           path: tarballs
   test-tarball-linux:
-    env:
-      PYTHON_VERSION: '3.10'
     needs: build-tarball
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
         with:
           name: tarballs
           path: tarballs