-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http2: add http2stream.endAfterHeaders property
Indicates is the END_STREAM flag was set on the received HEADERS frame Backport-PR-URL: #22850 PR-URL: #22843 Fixes: #22497 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
- Loading branch information
1 parent
bae7c60
commit 2de17ea
Showing
3 changed files
with
69 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
const assert = require('assert'); | ||
const http2 = require('http2'); | ||
const Countdown = require('../common/countdown'); | ||
|
||
const server = http2.createServer(); | ||
server.on('stream', common.mustCall((stream, headers) => { | ||
const check = headers[':method'] === 'GET' ? true : false; | ||
assert.strictEqual(stream.endAfterHeaders, check); | ||
stream.on('data', common.mustNotCall()); | ||
stream.on('end', common.mustCall()); | ||
stream.respond(); | ||
stream.end('ok'); | ||
}, 2)); | ||
|
||
const countdown = new Countdown(2, () => server.close()); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
{ | ||
const client = http2.connect(`http://localhost:${server.address().port}`); | ||
const req = client.request(); | ||
|
||
req.resume(); | ||
req.on('response', common.mustCall(() => { | ||
assert.strictEqual(req.endAfterHeaders, false); | ||
})); | ||
req.on('end', common.mustCall(() => { | ||
client.close(); | ||
countdown.dec(); | ||
})); | ||
} | ||
{ | ||
const client = http2.connect(`http://localhost:${server.address().port}`); | ||
const req = client.request({ ':method': 'POST' }); | ||
|
||
req.resume(); | ||
req.end(); | ||
req.on('response', common.mustCall(() => { | ||
assert.strictEqual(req.endAfterHeaders, false); | ||
})); | ||
req.on('end', common.mustCall(() => { | ||
client.close(); | ||
countdown.dec(); | ||
})); | ||
} | ||
})); |