Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: add http2stream.endAfterHeaders property #22843

Closed
wants to merge 1 commit into from
Closed

http2: add http2stream.endAfterHeaders property #22843

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 13, 2018

Indicates is the END_STREAM flag was set on the received HEADERS frame

Fixes: #22497

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell
http2: add http2stream.endAfterHeaders property
0a9b77c 
Indicates is the END_STREAM flag was set on the received HEADERS frame
@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/880/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 13, 2018
@jasnell jasnell added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. and removed dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 13, 2018
@jasnell jasnell mentioned this pull request Sep 13, 2018
Closed
@jasnell
Copy link
Member Author

jasnell commented Sep 13, 2018

Refs: #22497

@dougwilson
Copy link
Member

Nice! Is this available in the compat API or just the http2 API?

@jasnell
Copy link
Member Author

jasnell commented Sep 13, 2018 via email

mcollina
mcollina approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vsemozhetbyt
vsemozhetbyt reviewed Sep 13, 2018
View reviewed changes
doc/api/http2.md

* {boolean}

Set the `true` if the `END_STREAM` flag was set in the request or response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the -> Set to?

doc/api/http2.md
* {boolean}

Set the `true` if the `END_STREAM` flag was set in the request or response
HEADERS frame received, indicating that no additional data should be received
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEADERS -> `HEADERS`?

@trivikr
Copy link
Member

trivikr commented Sep 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17202/

@mcollina
Copy link
Member

mcollina commented Sep 17, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17224/
CI: https://ci.nodejs.org/job/node-test-pull-request/17239/

@mcollina mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. labels Sep 17, 2018
@addaleax addaleax removed the needs-ci PRs that need a full CI run. label Sep 17, 2018
@addaleax
Copy link
Member

Landed in efe0bbc

@addaleax addaleax closed this Sep 17, 2018
addaleax pushed a commit that referenced this pull request Sep 17, 2018
@jasnell @addaleax
http2: add http2stream.endAfterHeaders property
efe0bbc 
Indicates is the END_STREAM flag was set on the received HEADERS frame

PR-URL: #22843
Fixes: #22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 18, 2018
@jasnell @targos
http2: add http2stream.endAfterHeaders property
567be10 
Indicates is the END_STREAM flag was set on the received HEADERS frame

PR-URL: #22843
Fixes: #22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos added a commit that referenced this pull request Sep 18, 2018
@targos
2018-09-19, Version 10.11.0 (Current)
4958ee3 
Notable changes:

* fs
  * Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If
    this option is set to `true`, non-existing parent folders will be
    automatically created.
    #21875
  * Fixed fsPromises.readdir `withFileTypes`.
    #22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    #22843
* module
  * Added `module.createRequireFromPath(filename)`. This new method can
    be used to create a custom `require` function that will resolve
    modules relative to the `filename` path.
    #19360
* url
  * Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These
    methods can be used to correctly convert between `file:` URLs and
    absolute paths.
    #22506
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    #22620
* Windows
  * The Windows msi installer now provides an option to automatically
    install the tools required to build native modules.
    #22645
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: #22932
This was referenced Sep 18, 2018
Closed
Closed
targos pushed a commit that referenced this pull request Sep 19, 2018
@jasnell @targos
http2: add http2stream.endAfterHeaders property
1433653 
Indicates is the END_STREAM flag was set on the received HEADERS frame

PR-URL: #22843
Fixes: #22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2018
@targos
2018-09-19, Version 10.11.0 (Current)
960717b 
Notable changes:

* fs
  * Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If
    this option is set to `true`, non-existing parent folders will be
    automatically created.
    #21875
  * Fixed fsPromises.readdir `withFileTypes`.
    #22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    #22843
* module
  * Added `module.createRequireFromPath(filename)`. This new method can
    be used to create a custom `require` function that will resolve
    modules relative to the `filename` path.
    #19360
* url
  * Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These
    methods can be used to correctly convert between `file:` URLs and
    absolute paths.
    #22506
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    #22620
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: #22932
targos pushed a commit that referenced this pull request Sep 20, 2018
@jasnell @targos
http2: add http2stream.endAfterHeaders property
790864b 
Indicates is the END_STREAM flag was set on the received HEADERS frame

PR-URL: #22843
Fixes: #22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Sep 20, 2018
@targos
2018-09-20, Version 10.11.0 (Current)
8c70b20 
Notable changes:

* fs
  * Fixed fsPromises.readdir `withFileTypes`.
    #22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    #22843
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    #22620
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: #22932
targos added a commit that referenced this pull request Sep 20, 2018
@targos
2018-09-20, Version 10.11.0 (Current)
df9abb6 
Notable changes:

* fs
  * Fixed fsPromises.readdir `withFileTypes`.
    #22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    #22843
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    #22620
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: #22932
@sogaani sogaani mentioned this pull request Sep 21, 2018
Open
kjin pushed a commit to kjin/node that referenced this pull request Oct 3, 2018
@jasnell @kjin
http2: add http2stream.endAfterHeaders property
210a1d7 
Indicates is the END_STREAM flag was set on the received HEADERS frame

PR-URL: nodejs#22843
Fixes: nodejs#22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell @kjin
http2: add http2stream.endAfterHeaders property
565d9d8 
Indicates is the END_STREAM flag was set on the received HEADERS frame

PR-URL: nodejs#22843
Fixes: nodejs#22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell @BethGriggs
http2: add http2stream.endAfterHeaders property
2de17ea 
Indicates is the END_STREAM flag was set on the received HEADERS frame

Backport-PR-URL: #22850
PR-URL: #22843
Fixes: #22497
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @nodejs-github-bot @dougwilson @trivikr @mcollina @addaleax @cjihrig @vsemozhetbyt