Skip to content

Commit

Permalink
tools: use Ubuntu 24.04 and Clang on GitHub actions
Browse files Browse the repository at this point in the history
This puts us closer to what V8 actively supports.
GCC is still covered a lot by Jenkins CI.

Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
  • Loading branch information
targos and MoLow committed Jun 6, 2024
1 parent 5469d04 commit 31d920f
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 22 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: sccache clang
CXX: sccache clang++
SCCACHE_GHA_ENABLED: 'true'

permissions:
contents: read

jobs:
build-tarball:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand All @@ -63,7 +66,7 @@ jobs:
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,17 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: sccache clang
CXX: sccache clang++
SCCACHE_GHA_ENABLED: 'true'

permissions:
contents: read

jobs:
coverage-linux-without-intl:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
env:
CC: sccache gcc
CXX: sccache g++
SCCACHE_GHA_ENABLED: 'true'
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,17 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: sccache clang
CXX: sccache clang++
SCCACHE_GHA_ENABLED: 'true'

permissions:
contents: read

jobs:
coverage-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
env:
CC: sccache gcc
CXX: sccache g++
SCCACHE_GHA_ENABLED: 'true'
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ permissions:

jobs:
build-lto:
runs-on: ubuntu-latest
# not working on gcc-8 and gcc-9 see https://github.com/nodejs/node/issues/38570
container: gcc:11
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand All @@ -28,6 +26,6 @@ jobs:
run: npx envinfo
- name: Build lto
run: |
apt-get update && apt-get install ninja-build python-is-python3 -y
sudo apt-get update && sudo apt-get install ninja-build -y
./configure --enable-lto --ninja
ninja -C out/Release
6 changes: 5 additions & 1 deletion .github/workflows/test-internet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- .github/workflows/test-internet.yml
- test/internet/**
- internal/dns/**
- lib/dns.js
Expand All @@ -19,6 +20,7 @@ on:
- v[0-9]+.x-staging
- v[0-9]+.x
paths:
- .github/workflows/test-internet.yml
- test/internet/**
- internal/dns/**
- lib/dns.js
Expand All @@ -31,14 +33,16 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: clang
CXX: clang++

permissions:
contents: read

jobs:
test-internet:
if: github.repository == 'nodejs/node' || github.event_name != 'schedule'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,17 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: sccache clang
CXX: sccache clang++
SCCACHE_GHA_ENABLED: 'true'

permissions:
contents: read

jobs:
test-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
env:
CC: sccache gcc
CXX: sccache g++
SCCACHE_GHA_ENABLED: 'true'
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
Expand Down

0 comments on commit 31d920f

Please sign in to comment.