Skip to content

Commit

Permalink
test: move some gc tests back to parallel/, unmark flaky
Browse files Browse the repository at this point in the history
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and Trott committed Oct 13, 2018
1 parent 0d7328d commit 35f9218
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 11 deletions.
File renamed without changes.
11 changes: 0 additions & 11 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,8 @@ prefix sequential
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands
# on Node.js.
test-fs-readfile-tostring-fail: PASS, FLAKY
# https://github.com/nodejs/node/issues/23066
test-gc-http-client-timeout: PASS, FLAKY
# https://github.com/nodejs/node/issues/22336
test-gc-http-client: PASS,FLAKY
# https://github.com/nodejs/node/issues/23067
test-gc-net-timeout: PASS,FLAKY
# https://github.com/nodejs/node/issues/23089
test-gc-http-client-onerror: PASS,FLAKY
# https://github.com/nodejs/node/issues/23219
test-gc-http-client-connaborted: PASS,FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/22327
Expand Down

0 comments on commit 35f9218

Please sign in to comment.