Skip to content

Commit

Permalink
perf_hooks: remove non-existent entries from inspect
Browse files Browse the repository at this point in the history
Some of the milestones was removed in PR #21247 but entries not removed
from function for inspect PerformanceNodeTiming.

PR-URL: #29528
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
fanatid authored and Trott committed Sep 13, 2019
1 parent 7c9ee6d commit 39eb894
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
10 changes: 1 addition & 9 deletions lib/perf_hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,7 @@ class PerformanceNodeTiming extends PerformanceEntry {
bootstrapComplete: this.bootstrapComplete,
environment: this.environment,
loopStart: this.loopStart,
loopExit: this.loopExit,
thirdPartyMainStart: this.thirdPartyMainStart,
thirdPartyMainEnd: this.thirdPartyMainEnd,
clusterSetupStart: this.clusterSetupStart,
clusterSetupEnd: this.clusterSetupEnd,
moduleLoadStart: this.moduleLoadStart,
moduleLoadEnd: this.moduleLoadEnd,
preloadModuleLoadStart: this.preloadModuleLoadStart,
preloadModuleLoadEnd: this.preloadModuleLoadEnd
loopExit: this.loopExit
};
}
}
Expand Down
10 changes: 1 addition & 9 deletions test/parallel/test-trace-events-bootstrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,7 @@ const names = [
'v8Start',
'loopStart',
'loopExit',
'bootstrapComplete',
'thirdPartyMainStart',
'thirdPartyMainEnd',
'clusterSetupStart',
'clusterSetupEnd',
'moduleLoadStart',
'moduleLoadEnd',
'preloadModulesLoadStart',
'preloadModulesLoadEnd'
'bootstrapComplete'
];

if (process.argv[2] === 'child') {
Expand Down

0 comments on commit 39eb894

Please sign in to comment.