Skip to content

Commit

Permalink
test: add node::MakeCallback() test coverage
Browse files Browse the repository at this point in the history
PR-URL: #3478
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
bnoordhuis committed Oct 23, 2015
1 parent 5f3fb1c commit 3a091d2
Show file tree
Hide file tree
Showing 3 changed files with 109 additions and 0 deletions.
40 changes: 40 additions & 0 deletions test/addons/make-callback/binding.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#include "node.h"
#include "v8.h"

#include "../../../src/util.h"

#include <vector>

namespace {

void MakeCallback(const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK(args[0]->IsObject());
CHECK(args[1]->IsFunction() || args[1]->IsString());
auto isolate = args.GetIsolate();
auto recv = args[0].As<v8::Object>();
std::vector<v8::Local<v8::Value>> argv;
for (size_t n = 2; n < static_cast<size_t>(args.Length()); n += 1) {
argv.push_back(args[n]);
}
v8::Local<v8::Value> result;
if (args[1]->IsFunction()) {
auto method = args[1].As<v8::Function>();
result =
node::MakeCallback(isolate, recv, method, argv.size(), argv.data());
} else if (args[1]->IsString()) {
auto method = args[1].As<v8::String>();
result =
node::MakeCallback(isolate, recv, method, argv.size(), argv.data());
} else {
UNREACHABLE();
}
args.GetReturnValue().Set(result);
}

void Initialize(v8::Local<v8::Object> target) {
NODE_SET_METHOD(target, "makeCallback", MakeCallback);
}

} // namespace anonymous

NODE_MODULE(binding, Initialize)
8 changes: 8 additions & 0 deletions test/addons/make-callback/binding.gyp
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
'targets': [
{
'target_name': 'binding',
'sources': [ 'binding.cc' ]
}
]
}
61 changes: 61 additions & 0 deletions test/addons/make-callback/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
'use strict';

const common = require('../../common');
const assert = require('assert');
const vm = require('vm');
const binding = require('./build/Release/binding');
const makeCallback = binding.makeCallback;

assert.strictEqual(42, makeCallback(process, common.mustCall(function() {
assert.strictEqual(0, arguments.length);
assert.strictEqual(this, process);
return 42;
})));

assert.strictEqual(42, makeCallback(process, common.mustCall(function(x) {
assert.strictEqual(1, arguments.length);
assert.strictEqual(this, process);
assert.strictEqual(x, 1337);
return 42;
}), 1337));

const recv = {
one: common.mustCall(function() {
assert.strictEqual(0, arguments.length);
assert.strictEqual(this, recv);
return 42;
}),
two: common.mustCall(function(x) {
assert.strictEqual(1, arguments.length);
assert.strictEqual(this, recv);
assert.strictEqual(x, 1337);
return 42;
}),
};

assert.strictEqual(42, makeCallback(recv, 'one'));
assert.strictEqual(42, makeCallback(recv, 'two', 1337));

// Check that the callback is made in the context of the receiver.
const target = vm.runInNewContext(`
(function($Object) {
if (Object === $Object)
throw Error('bad');
return Object;
})
`);
assert.notStrictEqual(Object, makeCallback(process, target, Object));

// Runs in inner context.
const forward = vm.runInNewContext(`
(function(forward) {
return forward(Object);
})
`);
// Runs in outer context.
const endpoint = function($Object) {
if (Object === $Object)
throw Error('bad');
return Object;
};
assert.strictEqual(Object, makeCallback(process, forward, endpoint));

0 comments on commit 3a091d2

Please sign in to comment.