src: condense experimental warning message

PR-URL: #45424 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
nodejs · Dec 28, 2022 · 3dc6be6 · 3dc6be6
1 parent 6a03ac9
commit 3dc6be6
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 12 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -221,8 +221,7 @@ function slowCases(enc) {
 
 function emitExperimentalWarning(feature) {
   if (experimentalWarnings.has(feature)) return;
-  const msg = `${feature} is an experimental feature. This feature could ` +
-       'change at any time';
+  const msg = `${feature} is an experimental feature and might change at any time`;
   experimentalWarnings.add(feature);
   process.emitWarning(msg, 'ExperimentalWarning');
 }

diff --git a/src/node_process_events.cc b/src/node_process_events.cc
@@ -92,8 +92,7 @@ Maybe<bool> ProcessEmitExperimentalWarning(Environment* env,
 
   experimental_warnings.insert(warning);
   std::string message(warning);
-  message.append(
-      " is an experimental feature. This feature could change at any time");
+  message.append(" is an experimental feature and might change at any time");
   return ProcessEmitWarningGeneric(env, message.c_str(), "ExperimentalWarning");
 }
 

diff --git a/test/common/measure-memory.js b/test/common/measure-memory.js
@@ -43,9 +43,10 @@ function assertSingleDetailedShape(result) {
 }
 
 function expectExperimentalWarning() {
-  common.expectWarning('ExperimentalWarning',
-                       'vm.measureMemory is an experimental feature. ' +
-                       'This feature could change at any time');
+  common.expectWarning(
+    'ExperimentalWarning',
+    'vm.measureMemory is an experimental feature and might change at any time'
+  );
 }
 
 module.exports = {

diff --git a/test/parallel/test-vfs.js b/test/parallel/test-vfs.js
@@ -34,7 +34,8 @@ throws(() => require(vfsFile), { code: 'MODULE_NOT_FOUND' });
 
 common.expectWarning(
   'ExperimentalWarning',
-  'Module._stat is an experimental feature. This feature could change at any time');
+  'Module._stat is an experimental feature and might change at any time'
+);
 
 process.on('warning', common.mustCall());
 

diff --git a/test/wasi/test-wasi-symlinks.js b/test/wasi/test-wasi-symlinks.js
@@ -5,8 +5,7 @@ const path = require('path');
 
 if (process.argv[2] === 'wasi-child') {
   common.expectWarning('ExperimentalWarning',
-                       'WASI is an experimental feature. This feature could ' +
-                       'change at any time');
+                       'WASI is an experimental feature and might change at any time');
 
   const { WASI } = require('wasi');
   const wasmDir = path.join(__dirname, 'wasm');

diff --git a/test/wasi/test-wasi.js b/test/wasi/test-wasi.js
@@ -8,8 +8,7 @@ if (process.argv[2] === 'wasi-child') {
   const path = require('path');
 
   common.expectWarning('ExperimentalWarning',
-                       'WASI is an experimental feature. This feature could ' +
-                       'change at any time');
+                       'WASI is an experimental feature and might change at any time');
 
   const { WASI } = require('wasi');
   tmpdir.refresh();