fixup! src: use generic helper for splitting strings

nodejs · Jan 7, 2019 · 3e744fe · 3e744fe
1 parent edfb8b6
commit 3e744fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -283,7 +283,7 @@ static struct {
       tracing_file_writer_ = tracing_agent_->DefaultHandle();
     } else {
       std::vector<std::string> categories =
-          SplitString(per_process::cli_options->trace_event_categories);
+          SplitString(per_process::cli_options->trace_event_categories, ',');
 
       tracing_file_writer_ = tracing_agent_->AddClient(
           std::set<std::string>(std::make_move_iterator(categories.begin()),

diff --git a/src/util.h b/src/util.h
@@ -523,7 +523,7 @@ struct FunctionDeleter {
 template <typename T, void (*function)(T*)>
 using DeleteFnPtr = typename FunctionDeleter<T, function>::Pointer;
 
-std::vector<std::string> SplitString(const std::string& in, char delim = ',');
+std::vector<std::string> SplitString(const std::string& in, char delim);
 
 inline v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
                                            const std::string& str,