Skip to content

Commit

Permalink
lib: remove unused exec param
Browse files Browse the repository at this point in the history
`exec`'s parameters are now deconstructored through
`normalizeExecArgs.apply`. We don't need an exclipit parameter anymore
(and in fact it's NEVER referred in the code directly), like `spwan` or
`spwanSync`. This might be missing.

PR-URL: #22274
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information
MaleDong authored and targos committed Sep 3, 2018
1 parent 4d4180b commit 3f93782
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/child_process.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ function normalizeExecArgs(command, options, callback) {
}


exports.exec = function exec(command /* , options, callback */) {
var opts = normalizeExecArgs.apply(null, arguments);
exports.exec = function exec(/* command , options, callback */) {
const opts = normalizeExecArgs.apply(null, arguments);
return exports.execFile(opts.file,
opts.options,
opts.callback);
Expand Down

0 comments on commit 3f93782

Please sign in to comment.