fixup! src: remove duplicated code in GenerateSingleExecutableBlob()

nodejs · Aug 13, 2023 · 4026cf4 · 4026cf4
1 parent 844339d
commit 4026cf4
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/node_sea.cc b/src/node_sea.cc
@@ -486,16 +486,15 @@ ExitCode GenerateSingleExecutableBlob(
     }
   }
 
-  std::optional<std::string> optional_code_cache =
-      GenerateCodeCache(config.main_path, main_script);
-  if (!optional_code_cache.has_value()) {
-    FPrintF(stderr, "Cannot generate V8 code cache\n");
-    return ExitCode::kGenericUserError;
-  }
-
   std::optional<std::string_view> optional_sv_code_cache;
   std::string code_cache;
   if (static_cast<bool>(config.flags & SeaFlags::kUseCodeCache)) {
+    std::optional<std::string> optional_code_cache =
+    GenerateCodeCache(config.main_path, main_script);
+    if (!optional_code_cache.has_value()) {
+      FPrintF(stderr, "Cannot generate V8 code cache\n");
+      return ExitCode::kGenericUserError;
+    }
     code_cache = optional_code_cache.value();
     optional_sv_code_cache = code_cache;
   }