bootstrap: move global initialization to js

nodejs · Jun 30, 2022 · 41933c5 · 41933c5
1 parent 08c8e85
commit 41933c5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -402,6 +402,7 @@ function setupGlobalProxy() {
     enumerable: false,
     configurable: true
   });
+  globalThis.global = globalThis;
 }
 
 function setupBuffer() {

diff --git a/src/node.cc b/src/node.cc
@@ -343,9 +343,6 @@ MaybeLocal<Value> Environment::BootstrapNode() {
   EscapableHandleScope scope(isolate_);
 
   Local<Object> global = context()->Global();
-  // TODO(joyeecheung): this can be done in JS land now.
-  global->Set(context(), FIXED_ONE_BYTE_STRING(isolate_, "global"), global)
-      .Check();
 
   // process, require, internalBinding, primordials
   std::vector<Local<String>> node_params = {