address nits

nodejs · Feb 2, 2021 · 44d49e0 · 44d49e0
1 parent 5ca795c
commit 44d49e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/doc/api/crypto.md b/doc/api/crypto.md
@@ -1351,7 +1351,7 @@ added: v11.6.0
 changes:
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/37081
-    description: Added support for `'jwk' format`.
+    description: Added support for `'jwk'` format.
 -->
 
 * `options`: {Object}

diff --git a/test/parallel/test-crypto-key-objects.js b/test/parallel/test-crypto-key-objects.js
@@ -659,10 +659,10 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
   // SecretKeyObject export buffer format (default)
   const buffer = Buffer.from('Hello World');
   const keyObject = createSecretKey(buffer);
-  assert(buffer.equals(keyObject.export()));
-  assert(buffer.equals(keyObject.export({})));
-  assert(buffer.equals(keyObject.export({ format: 'buffer' })));
-  assert(buffer.equals(keyObject.export({ format: undefined })));
+  assert.deepStrictEqual(keyObject.export(), buffer);
+  assert.deepStrictEqual(keyObject.export({}), buffer);
+  assert.deepStrictEqual(keyObject.export({ format: 'buffer' }), buffer);
+  assert.deepStrictEqual(keyObject.export({ format: undefined }), buffer);
 }
 
 {
@@ -681,6 +681,7 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
   // Find an unsupported curve regardless of whether a FIPS compliant crypto
   // provider is currently in use.
   const namedCurve = getCurves().find((curve) => !supported.includes(curve));
+  assert(namedCurve);
   const keyPair = generateKeyPairSync('ec', { namedCurve });
   const { publicKey, privateKey } = keyPair;
   assert.throws(