Skip to content

Commit

Permalink
deps: V8: extend workaround for MSVC optimizer bug
Browse files Browse the repository at this point in the history
Builds are starting to fail in CI with V8 7.5 and 7.6.

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: #28286
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
targos committed Jun 20, 2019
1 parent 8aeb9cc commit 47366d7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deps/v8/src/builtins/setup-builtins-internal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,

} // namespace

#if _MSC_VER == 1920
#ifdef _MSC_VER
#pragma optimize( "", off )
#endif

Expand Down Expand Up @@ -384,7 +384,7 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
builtins->MarkInitialized();
}

#if _MSC_VER == 1920
#ifdef _MSC_VER
#pragma optimize( "", on )
#endif

Expand Down

0 comments on commit 47366d7

Please sign in to comment.