Skip to content

Commit

Permalink
build: refactor configure.py
Browse files Browse the repository at this point in the history
- Replace usage of the deprecated `distutils` library with the
`packaging` library recommended by setuptools'
"Porting from Distutils" guide.
- Explicitly specify the encoding when opening files.
- Use f-strings to format strings.
- Use `isinstance()` for type checks instead of `type()`.
- Use the `with` keyword for resource-allocating operations.
- Avoid using multiple statements in a single line.
- Remove unnecessary `else` clauses after `return`.
- Iterate with the `items()` method of dictionaries when both the key
and value are used.
- Remove unnecessary parentheses.
- Rename unused unpacked variables to `_`, `_1`, etc etc.
- Rename the `list` variable to avoid conflict with the global
`list()` function.
- Remove unused `path` parameter of the `icu_download()` function.
- Remove unused return value of the `configure_section_file()`
function.
  • Loading branch information
VoltrexKeyva committed Apr 4, 2023
1 parent af8ed02 commit 4863d58
Showing 1 changed file with 124 additions and 124 deletions.
Loading

0 comments on commit 4863d58

Please sign in to comment.